Skip to content

chore: cleanup comments #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 15, 2026
+1 −9
Merged

chore: cleanup comments #7848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions apps/docs/app/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,8 +1013,6 @@ div.flex.flex-row.items-start.bg-fd-secondary.border.rounded-lg.text-xs {
display: none !important;
}

/* Method+path bar — cleaner, lighter styling like Gumloop.
Override bg-fd-card CSS variable directly for reliability. */
#nd-page:has(.api-page-header) div.flex.flex-row.items-center.rounded-xl.border.not-prose {
--color-fd-card: var(--surface-3) !important;
background-color: var(--surface-3) !important;
Expand Down
3 changes: 1 addition & 2 deletions apps/docs/lib/source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ const METHOD_COLORS: Record<string, string> = {
}

/**
* Custom openapi plugin that places method badges BEFORE the page name
* in the sidebar (like Mintlify/Gumloop) instead of after.
* Places HTTP method badges before page names in the sidebar.
*/
function openapiPluginBadgeLeft() {
return {
Expand Down
5 changes: 0 additions & 5 deletions apps/sim/lib/knowledge/access/drive-permissions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ describe('driveFileAcl', () => {
).toEqual(['u:alice@corp.com'])
})

/**
* The deviation from Onyx that matters most: their file path makes an
* `anyone` grant public without consulting `allowFileDiscovery`, so a file
* anyone ever shared by link becomes fully searchable.
*/
it('still refuses a link-only anyone share', () => {
expect(acl([{ type: 'anyone', allowFileDiscovery: false }], OPEN)).toEqual(['link'])
})
Expand Down
Loading