Skip to content

chore(files): align PDF viewer import order #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Sep 15, 2026
Merged

chore(files): align PDF viewer import order #7846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/pdf-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
*/
import '@/lib/core/utils/browser-polyfills'
import { memo, useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { bindPreviewWheelZoom } from '@sim/emcn'
import { createLogger } from '@sim/logger'
import { pdfjs, Document as ReactPdfDocument, Page as ReactPdfPage } from 'react-pdf'
Comment on lines +9 to 11

@greptile-apps greptile-apps Bot Sep 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Incorrect import grouping

The reordered imports place the @sim/emcn UI component import before the external @sim/logger and react-pdf imports. This violates the repository directive that external libraries must come before UI components, so the required import order must be restored before merging.

Suggested change
import { bindPreviewWheelZoom } from '@sim/emcn'
import { createLogger } from '@sim/logger'
import { pdfjs, Document as ReactPdfDocument, Page as ReactPdfPage } from 'react-pdf'
import { createLogger } from '@sim/logger'
import { pdfjs, Document as ReactPdfDocument, Page as ReactPdfPage } from 'react-pdf'
import { bindPreviewWheelZoom } from '@sim/emcn'

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

import 'react-pdf/dist/Page/TextLayer.css'
import { bindPreviewWheelZoom } from '@sim/emcn'
import { PREVIEW_LOADING_OVERLAY } from '@/app/workspace/[workspaceId]/files/components/file-viewer/preview-shared'
import { PreviewToolbar } from '@/app/workspace/[workspaceId]/files/components/file-viewer/preview-toolbar'
import 'react-pdf/dist/Page/TextLayer.css'

/**
* The worker runs in its own context that browser-polyfills cannot reach, so
Expand Down
Loading