Skip to content

chore(files): align PDF viewer import order - #7846

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/investigate-lightbox-followup
Sep 15, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/investigate-lightbox-followup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Place the PDF viewer stylesheet after module imports while preserving the browser polyfill's required evaluation order.

Type of Change

  • Maintenance

Testing

  • All eight cleanup passes, repository lint, ship audits, and docs manifest check pass.
  • Sim type check and diff checks pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 2:52am UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit 7ae92b7 into staging Sep 15, 2026
25 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/investigate-lightbox-followup branch September 15, 2026 02:52
@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The runtime behavior appears safe, but the explicit repository import-order requirement must be satisfied before merging.

Findings

  1. P2 Incorrect import grouping

Summary

This PR moves the React PDF text-layer stylesheet after module imports while retaining the required browser-polyfill ordering.

  • The polyfill remains before react-pdf, preserving its module-evaluation requirement.
  • The stylesheet move does not conflict with another text-layer stylesheet.
  • The reordered @sim/emcn import does not follow the repository’s required import grouping.

Reviews (1) · Last reviewed commit: "chore(files): align PDF viewer import or..."

Comment on lines +9 to 11
import { bindPreviewWheelZoom } from '@sim/emcn'
import { createLogger } from '@sim/logger'
import { pdfjs, Document as ReactPdfDocument, Page as ReactPdfPage } from 'react-pdf'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Incorrect import grouping

The reordered imports place the @sim/emcn UI component import before the external @sim/logger and react-pdf imports. This violates the repository directive that external libraries must come before UI components, so the required import order must be restored before merging.

Suggested change
import { bindPreviewWheelZoom } from '@sim/emcn'
import { createLogger } from '@sim/logger'
import { pdfjs, Document as ReactPdfDocument, Page as ReactPdfPage } from 'react-pdf'
import { createLogger } from '@sim/logger'
import { pdfjs, Document as ReactPdfDocument, Page as ReactPdfPage } from 'react-pdf'
import { bindPreviewWheelZoom } from '@sim/emcn'

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant