Skip to content

fix(workflows): preserve absent loop count fields - #7845

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/workflow-load-count-shape
Sep 15, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/workflow-load-count-shape

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve omitted loop count fields when repairing invalid legacy values. The loader now adds a replacement count only when an invalid stored value is present.
  • Add a regression assertion that omitted counts stay absent and retain the existing serialization default.

Type of Change

  • Bug fix

Testing

240 app tests and 15 shared persistence tests passed, including loop modes, serialization, collection iteration, response validation, retry recovery, and stale request failures. Lint, affected workspace type checks, all 46 repository audits, block registry validation, and docs manifest validation passed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 2:41am UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

Summary

This PR corrects normalized workflow loading so an omitted loop count remains structurally absent rather than becoming an own property with an undefined value.

  • Repairs present invalid legacy count values from the normalized loop record.
  • Preserves valid numeric counts without changing their values.
  • Adds a regression assertion covering both the value and own-property shape of an omitted count.

Reviews (1) · Last reviewed commit: "fix(workflows): preserve absent loop cou..."

@waleedlatif1
waleedlatif1 merged commit 3889e4b into staging Sep 15, 2026
33 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/workflow-load-count-shape branch September 15, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant