Skip to content

feat(slack): support organization-scoped shared app rollout - #7833

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/slack-search-org-rollout
Sep 15, 2026
Merged

TheodoreSpeaks merged 1 commit into
stagingfrom
codex/slack-search-org-rollout

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Allow organization-specific rollout of the shared Slack Search app through the existing feature flag.
  • Use the owning organization for setup, OAuth callbacks, personal connections, and bot execution checks.

Type of Change

  • Improvement

Testing

141 focused tests passed. Repository lint, block registry, generated-artifact checks, and the full audit suite passed. Typechecks are left to CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 15, 2026 1:04am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; organization ownership is consistently propagated and revalidated across shared-app setup and execution paths.

Summary

This PR changes the shared Slack Search app rollout from a deployment-wide decision to an organization-scoped feature-flag decision.

  • Propagates canonical organization ownership through setup, OAuth callbacks, managed personal connections, installation management, and bot execution authorization.
  • Rechecks organization-specific availability at OAuth and execution lifecycle boundaries.
  • Preserves global fallback behavior and keeps custom Slack apps independent of the shared-app rollout.
  • Adds focused tests for organization allowlisting, withdrawal of access, OAuth state handling, and execution reauthorization.

Diagram

sequenceDiagram
  participant Admin
  participant Setup as Slack Setup
  participant Flag as Feature Flags
  participant Slack
  participant DB
  participant Worker as Bot Worker

  Admin->>Setup: Start shared-app setup for organization
  Setup->>Flag: Check shared app with orgId
  Flag-->>Setup: Organization enabled
  Setup->>Slack: Begin OAuth
  Slack-->>Setup: OAuth callback
  Setup->>Flag: Recheck with owning orgId
  Setup->>DB: Persist installation and credential
  Slack->>Worker: Deliver event
  Worker->>DB: Load installation and owning organization
  Worker->>Flag: Recheck shared app with installation orgId
  Flag-->>Worker: Enabled or denied
  Worker->>Slack: Execute bot response when enabled
Loading

Reviews (1) · Last reviewed commit: "feat(slack): support organization-scoped..."

@TheodoreSpeaks
TheodoreSpeaks merged commit 4460a0a into staging Sep 15, 2026
33 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/slack-search-org-rollout branch September 15, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant