feat(audit): record the client surface on audit entries and identify CLI login requests - #7823
Merged
Merged
Conversation
…CLI login requests
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
surfacecolumn toaudit_log(web,desktop,cli,sdk-js,sdk-python), written from the client the route wrapper already resolves per request, so every audit entry recorded while serving a request says which client it came fromrecordAudit,recordAuditBatch, andrecordAuditOnce, so no caller changes; null for background work and callers that don't identify themselves0344_audit_log_surfaceis a singleADD COLUMN ... text(nullable, no default): metadata-only, compatible with the deployed app, which never writes it, and no contract step to follow. The snapshot diff is that one columnX-Sim-Client-Infolike every other CLI request, so they carry the coding agent instead of falling back to user-agent attributionidentityHeaders()helper now supplies the user agent and client info for the API client and all three login requests, replacing four hand-written copiesclientInfoHeaderbarrel exportType of Change
Testing
bun run check:migrations,bun run lint,check:audits, anddocs-manifest:checkpass; full apps/sim suite passes apart from one unrelated timing test that passes on rerunChecklist