fix(cli): read the telemetry token per call so tests don't depend on the publish job's env - #7822
Merged
Merged
Conversation
…the publish job's env
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim telemetry statushas a test asserting that a build without a reporting token reports nothing, and it read the token from the ambient environment. The publish job now sets the token for the whole job, so the test saw one and failed, and nothing was publishedbuiltInIngestTarget()is called instead of at module load. The reads stay literalprocess.env.SIM_CLI_TELEMETRY_*expressions, so the bundler still inlines them into the published buildpackages/sim-cli, so merging it runs the publish againType of Change
Testing
prepublishOnlyrebuild): the shipped bundle has the token inlined, no raw env reads left, andsim telemetry statusreports onbun run lint,check:audits, anddocs-manifest:checkpassChecklist