fix(copilot): import the block registry statically in context resolution - #7816
Merged
Merged
Conversation
processBlockMetadata loaded @/blocks/registry with a dynamic import even though the module already reaches it statically through permission-groups/block-access. Concurrent dynamic imports of the mocked registry intermittently resolved the real registry under vitest, costing seconds and timing out the block-context test on CI. A static import is equivalent at runtime and removes the race.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…t still defers the registry
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processBlockMetadataloaded@/blocks/registrywith a dynamicimport(), butprocess-contents.tsalready reaches the registry statically throughlib/permission-groups/block-access.ts, so the lazy load bought nothing at runtimeresolves integration mentions through the same metadata and access policy as blockson slower CI runnersgetBlockRegistrystatically; runtime behavior is unchanged and every test call now gets the mockType of Change
Testing
process-contents.test.ts: slow test 2489ms → 1ms, file tests 2.5s → ~22ms across repeated runs; all registry reads confirmed to hit the mocklib/copilot+app/api/mothershipsuites (2434 tests), type-check,bun run lint,check:audits, block registry, docs manifestChecklist