Skip to content

fix(slack): read shared app credentials from the environment - #7773

Merged
TheodoreSpeaks merged 3 commits into
stagingfrom
codex/shared-slack-env
Sep 11, 2026
Merged

fix(slack): read shared app credentials from the environment#7773
TheodoreSpeaks merged 3 commits into
stagingfrom
codex/shared-slack-env

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Read shared Slack app credentials directly from the deployment environment for webhook verification and bot/member OAuth. Remove the manual registration step and keep secrets out of saved setup attempts.
  • Create app identity metadata during installation, preserve custom-app credential handling, and invalidate pending work when deployment credentials rotate. Existing shared installations need reconnecting once to adopt the new revision.
  • Include the requested expanded official-app manifest permissions; runtime OAuth requirements remain unchanged.

Type of Change

  • Bug fix

Testing

336 focused tests, lint, 46 repository audits, generated-artifact checks, and migration safety pass. CI build, typechecks, full test suites, and both PostgreSQL integration jobs pass on the latest commit. Renaming the shared-app environment module cleared the Turbopack filename collision for this build; Next.js remains on stable. Greptile reports 5/5 with no unresolved review threads.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 11, 2026 6:24pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding findings.

Summary

  • Resolves shared-app credentials from environment variables for webhook verification and OAuth.
  • Keeps shared OAuth attempts free of deployment secrets and invalidates pending work when credentials rotate.
  • Creates metadata-only shared-app rows during installation while preserving encrypted custom-app credentials.
  • Expands the official Slack app manifest permissions.
  • Renames the environment-backed configuration module and updates all references.

Diagram

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Env[Deployment environment] --> Resolver[Shared Slack app resolver]
  Resolver --> Webhook[Webhook signature verification]
  Resolver --> OAuth[Bot and member OAuth]
  OAuth --> State[Secret-free pending state]
  OAuth --> Identity[Metadata-only shared app row]
  DB[(Database)] --> Custom[Custom app credentials]
  Custom --> Webhook
  Custom --> OAuth
Loading

Reviews (3) · Last reviewed commit: "chore(slack): rename shared app environm..."

greptile-apps[bot]
greptile-apps Bot reviewed Sep 11, 2026
View reviewed changes
Comment thread packages/db/migrations/0340_slack_shared_app_env.sql Outdated
@TheodoreSpeaks

TheodoreSpeaks commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

TheodoreSpeaks commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks

TheodoreSpeaks commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 4d1c9d0 into staging Sep 11, 2026
33 of 34 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/shared-slack-env branch September 11, 2026 19:39
@waleedlatif1 waleedlatif1 mentioned this pull request Sep 11, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheodoreSpeaks