fix(knowledge): purge trashed Google Sheets tabs on a normal sync by waleedlatif1 · Pull Request #5883 · simstudioai/sim

waleedlatif1 · 2026-07-23T05:47:15Z

Summary

Follow-up to fix(connectors): purge archived/deleted source items in KB connectors #5880 — Cursor Bugbot flagged ( v0.7.43: ci and connector fixes #5882 (comment)) that a trashed Google Sheets spreadsheet never actually gets purged on a normal sync, contradicting the docs.
Root cause: the sync engine's zero-document guard skips deletion reconciliation whenever a listing comes back empty and documents already exist, since it can't tell a genuinely empty source apart from a transient provider outage. Google Sheets is a single-spreadsheet-per-connector integration, so trashing the one source item empties the entire listing — the guard fired every time, and only a forced full resync could complete the cleanup.
Added shouldSkipEmptyListing to sync-engine.ts, mirroring the existing shouldReconcileDeletions helper: a connector can set syncContext.sourceConfirmedEmpty to vouch that it positively confirmed the empty result against the source (not merely inferred it from an empty listing page). Google Sheets sets this flag when its direct Drive metadata lookup confirms the spreadsheet is trashed.
No other connector sets this flag, so behavior everywhere else is unchanged.

Type of Change

Bug fix

Testing

Added unit tests for shouldSkipEmptyListing covering: non-empty listing, no existing docs, forced fullSync, default skip behavior, and the new sourceConfirmedEmpty override (including a falsy-value case).
Updated Google Sheets connector tests to assert sourceConfirmedEmpty is set only on the trashed path, and left unset on the absent/false/fail-open paths.
bun run lint, tsc --noEmit, and the full connectors + lib/knowledge/connectors test suites (411 tests) all pass.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Trashing a spreadsheet made listDocuments return an empty listing, but the sync engine's zero-document guard skips deletion reconciliation whenever a listing comes back empty and documents already exist — it can't tell a genuinely empty source apart from a provider outage. For a single-spreadsheet connector, trashing its one source item empties the entire listing, so the guard always fired and the stale tabs never got cleaned up on a normal sync, contradicting the documented behavior. Add shouldSkipEmptyListing, mirroring shouldReconcileDeletions: a connector can now set syncContext.sourceConfirmedEmpty when it has positively confirmed the empty result against the source (not merely inferred it from an empty listing page), letting reconciliation proceed. The Google Sheets connector sets this flag when it confirms the spreadsheet is trashed via a direct Drive metadata lookup. No other connector sets it, so this doesn't change behavior anywhere else.

vercel · 2026-07-23T05:47:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 23, 2026 5:52am

cursor · 2026-07-23T05:47:26Z

PR Summary

Medium Risk
Changes knowledge-base deletion reconciliation and can hard-delete stored documents when a connector sets sourceConfirmedEmpty; scope is narrow (only Google Sheets today) but touches data-loss safety guards.

Overview
Fixes trashed Google Sheets never purging on a normal sync — the sync engine treated an empty listing like a possible outage and skipped deletion reconciliation (and could block large deletions), so only a forced full resync cleaned up.

Connectors can set syncContext.sourceConfirmedEmpty when they positively verify the source is empty (not just an empty page). The sync engine refactors this into shouldSkipEmptyListing and exceedsDeletionSafetyThreshold, both of which honor that flag. Google Sheets sets it when Drive metadata confirms the spreadsheet is trashed. Other connectors are unchanged.

^{Reviewed by Cursor Bugbot for commit 147572d. Configure here.}

greptile-apps · 2026-07-23T05:49:08Z

Greptile Summary

This PR purges indexed Google Sheets tabs during a normal sync after the source spreadsheet is trashed. The main changes are:

Marks an empty listing as confirmed after Drive reports the spreadsheet as trashed.
Lets confirmed empty sources pass both deletion safety guards.
Adds tests for connector flag propagation and guard behavior.

Confidence Score: 5/5

This looks safe to merge.

The confirmed-empty flag now bypasses both guards that blocked the purge.
The flag is scoped to one sync and requires an explicit trashed response.
Existing incremental and truncated-listing protections remain in place.

Important Files Changed

Filename	Overview
apps/sim/connectors/google-sheets/google-sheets.ts	Confirms an empty source only when Drive explicitly reports the configured spreadsheet as trashed.
apps/sim/lib/knowledge/connectors/sync-engine.ts	Allows a confirmed empty source to pass the empty-listing and mass-deletion guards.
apps/sim/connectors/google-sheets/google-sheets.test.ts	Tests confirmed-empty state for trashed, active, malformed, and failed metadata responses.
apps/sim/lib/knowledge/connectors/sync-engine.test.ts	Tests the new guard helpers, including confirmed-empty and forced-sync behavior.

_{Reviews (2): Last reviewed commit: "fix(knowledge): let sourceConfirmedEmpty..." | Re-trigger Greptile}

…n safety threshold The zero-document guard bypass alone wasn't enough: for a trashed spreadsheet with more than 5 tabs, reconciliation would proceed but the separate mass-deletion ratio guard (>50% deleted, >5 docs) still blocked the actual delete on a normal sync, requiring a forced full resync anyway. Extracted the ratio guard into exceedsDeletionSafetyThreshold, mirroring shouldSkipEmptyListing, so a connector's positive source confirmation bypasses both guards consistently.

waleedlatif1 · 2026-07-23T05:53:01Z

@greptile

waleedlatif1 · 2026-07-23T05:53:02Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 147572d. Configure here.}

waleedlatif1 · 2026-07-23T06:55:36Z

Follow-up: the sourceConfirmedEmpty bypass approach merged here was reconsidered and replaced with a more general fix in #5884 — a two-phase tombstone mechanism that doesn't need a connector-specific escape hatch. See #5884 for the rationale.

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/connectors/sync-engine.ts

waleedlatif1 mentioned this pull request Jul 23, 2026

v0.7.43: ci and connector fixes #5882

Merged

greptile-apps Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/connectors/sync-engine.ts

vercel Bot temporarily deployed to Preview July 23, 2026 05:52 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

waleedlatif1 merged commit 387fa37 into staging Jul 23, 2026
20 checks passed

waleedlatif1 deleted the fix/gsheets-trashed-empty-guard branch July 23, 2026 06:14

waleedlatif1 mentioned this pull request Jul 23, 2026

fix(knowledge): replace deletion-safety heuristics with a two-phase tombstone #5884

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(knowledge): purge trashed Google Sheets tabs on a normal sync#5883

fix(knowledge): purge trashed Google Sheets tabs on a normal sync#5883
waleedlatif1 merged 2 commits into
stagingfrom
fix/gsheets-trashed-empty-guard

waleedlatif1 commented Jul 23, 2026

Uh oh!

vercel Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Jul 23, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Jul 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Jul 23, 2026 •

edited

Loading

cursor Bot commented Jul 23, 2026 •

edited

Loading

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading