Skip to content

fix(auth): gate email-otp auto-signup behind DISABLE_EMAIL_SIGNUP #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Jul 22, 2026
+17 −5
Merged

fix(auth): gate email-otp auto-signup behind DISABLE_EMAIL_SIGNUP #5840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3421b4
fix(auth): gate email-otp auto-signup behind DISABLE_EMAIL_SIGNUP
waleedlatif1 Jul 22, 2026
ba91922
fix(auth): also close otp auto-signup under DISABLE_REGISTRATION
waleedlatif1 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions apps/sim/lib/auth/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,13 @@ export const auth = betterAuth({
},
emailAndPassword: {
enabled: true,
/**
* Same flag that hides the email/password signup form (DISABLE_EMAIL_SIGNUP).
* Blocks /sign-up/email at the better-auth layer so ripping out the frontend
* form cannot be bypassed by calling the endpoint directly. Existing users
* can still sign in.
*/
disableSignUp: isEmailSignupDisabled,
requireEmailVerification: isEmailVerificationEnabled,
/**
* When someone signs up with an already-registered email, better-auth returns a
Expand Down Expand Up @@ -891,11 +898,6 @@ export const auth = betterAuth({
})
}

if (isEmailSignupDisabled && ctx.path.startsWith('/sign-up/email'))
throw new APIError('FORBIDDEN', {
message: 'Email sign-up is disabled. Please use Google, Microsoft, or GitHub.',
})

const isSignIn = ctx.path.startsWith('/sign-in')
const isSignUp = ctx.path.startsWith('/sign-up')

Expand Down Expand Up @@ -1039,6 +1041,16 @@ export const auth = betterAuth({
throw error
}
},
/**
* Without this, /sign-in/email-otp auto-registers any unknown email —
* bypassing the signup gate entirely (no captcha, no /sign-up path).
* Gated by the same DISABLE_EMAIL_SIGNUP flag as the signup form (and by
* DISABLE_REGISTRATION, whose /sign-up path check has the same blind
* spot); when set, better-auth also silently skips sending OTPs to
* unknown emails (enumeration-safe) while existing users keep OTP
* sign-in.
*/
disableSignUp: isEmailSignupDisabled || isRegistrationDisabled,
sendVerificationOnSignUp: false,
otpLength: 6, // Explicitly set the OTP length
expiresIn: 15 * 60, // 15 minutes in seconds
Expand Down
Loading