Skip to content

improvement(search-modal): remove matched-character bolding and move SearchHighlight into knowledge#5822

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-modal-remove-highlight
Jul 21, 2026
Merged

improvement(search-modal): remove matched-character bolding and move SearchHighlight into knowledge#5822
waleedlatif1 merged 1 commit into
stagingfrom
improvement/search-modal-remove-highlight

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the font-medium bolding of matched characters in the sidebar search modal — the mixed weights looked strange
  • Delete the now-dead HighlightedText component and the query prop threading through every group/item component (items no longer re-render on each keystroke)
  • fuzzyMatch and its match positions are untouched — they still drive ranking
  • Move SearchHighlight out of components/ui into knowledge/[id]/components — the knowledge base pages are its only consumers

Type of Change

  • Improvement

Testing

25 search-modal utils tests pass; typecheck clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 21, 2026 10:35pm

Request Review

@cursor

cursor Bot commented Jul 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only search presentation and import path changes; knowledge highlighting behavior is preserved and fuzzy ranking is untouched.

Overview
Removes in-result text highlighting from the sidebar command palette: labels render as plain text instead of bolding fuzzy-matched characters. The HighlightedText helper and the query prop passed through every search group and memoized command item are deleted so list rows no longer re-render on each keystroke for highlight updates. fuzzyMatch / filtering and ranking are unchanged.

SearchHighlight is relocated from @/components/ui into knowledge/[id]/components (with a short doc comment); knowledge base and document pages import it from there, and the shared UI barrel no longer exports it.

Reviewed by Cursor Bugbot for commit 1b45461. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR simplifies search result rendering and moves knowledge-specific highlighting into the knowledge feature. The main changes are:

  • Removes matched-character bolding and query prop threading from the search modal.
  • Keeps fuzzy matching and result ranking unchanged.
  • Moves SearchHighlight from shared UI into the knowledge component directory.
  • Updates the knowledge pages and component barrels for the new location.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • Search filtering and ranking still use the deferred query.
  • The moved component's consumers use the new knowledge barrel.
  • Removed exports have no remaining repository consumers.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/components/command-items/command-items.tsx Removes query-dependent highlighting while preserving item labels, values, and selection callbacks.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/components/search-groups/search-groups.tsx Removes the unused query prop from search groups and their item calls.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx Stops passing the deferred query to presentation components while retaining query-driven filtering.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/search-highlight/search-highlight.tsx Relocates the existing highlight component into the knowledge feature without changing its behavior.
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/index.ts Exports the relocated highlight component through the knowledge component barrel.
apps/sim/components/ui/index.ts Removes the obsolete shared UI export after its consumers move to the knowledge feature.

Reviews (1): Last reviewed commit: "improvement(search-modal): remove matche..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit daa2416 into staging Jul 21, 2026
20 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-modal-remove-highlight branch July 21, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant