Skip to content

fix(sidebar): align workspace header loading-state spacing with chip geometry#5717

Merged
waleedlatif1 merged 1 commit into
stagingfrom
workspace-header-loading-spacing
Jul 16, 2026
Merged

fix(sidebar): align workspace header loading-state spacing with chip geometry#5717
waleedlatif1 merged 1 commit into
stagingfrom
workspace-header-loading-spacing

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The disabled/loading workspace header button hand-rolled its chrome with gap-2 (8px), while the loaded state renders through chipVariants() whose canonical geometry is gap-1.5 (6px) — so the icon-to-name spacing visibly shifted 2px when the workspace list finished loading
  • Replace the hand-rolled class list with the design system's chipGeometryClass (exported for exactly this case: matching chip shape without inheriting hover/cursor chrome), keeping the mx-0.5 and collapsed/expanded flex handling

Type of Change

  • Bug fix

Testing

Verified empirically against the emcn tokens (chipContentGap = 'gap-1.5' vs the hand-rolled gap-2); typecheck and lint pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 16, 2026 9:06pm

Request Review

@cursor

cursor Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Single-component styling change with no auth, data, or API impact.

Overview
Fixes a 2px layout shift in the sidebar workspace header while workspaces are still loading.

The disabled placeholder button no longer uses hand-rolled pill classes (gap-2, fixed height, padding). It now composes chipGeometryClass from @sim/emcn—the same geometry as the loaded chipVariants() trigger—while keeping mx-0.5 and collapsed vs expanded flex behavior.

Reviewed by Cursor Bugbot for commit 0ddb7cf. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR aligns the loading workspace header with the shared chip geometry. The main changes are:

  • Replaces duplicated geometry classes with chipGeometryClass.
  • Uses the canonical 6px chip content gap.
  • Preserves the existing margin and collapsed or expanded display classes.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workspace-header/workspace-header.tsx Uses the exported chip geometry token for the loading header while retaining its existing layout behavior.

Reviews (1): Last reviewed commit: "fix(sidebar): align workspace header loa..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 mentioned this pull request Jul 16, 2026
Merged
@waleedlatif1
waleedlatif1 merged commit a218ebe into staging Jul 16, 2026
20 checks passed
@waleedlatif1
waleedlatif1 deleted the workspace-header-loading-spacing branch July 16, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1