Skip to content

fix(settings): align recently-deleted icon colors with platform token#5691

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/recently-deleted-icon-colors
Jul 15, 2026
Merged

fix(settings): align recently-deleted icon colors with platform token#5691
waleedlatif1 merged 1 commit into
stagingfrom
fix/recently-deleted-icon-colors

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Folder and file-folder icons in the Recently Deleted settings page rendered with a hardcoded inline color (#6B7280 fallback) while every other row icon used var(--text-icon), so folder rows looked visibly lighter/off-token
  • Route all resource types through the shared RESOURCE_REGISTRY tab-icon renderers (which apply text-[var(--text-icon)]) instead of special-casing workflows and folders
  • Remove the now-unused color plumbing on DeletedResource and the dead icon imports

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jul 15, 2026 6:09pm

Request Review

@cursor

cursor Bot commented Jul 15, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Settings UI-only icon rendering change with no auth, data, or API impact.

Overview
Recently Deleted row icons no longer special-case workflows and folders with local icons and inline folder colors (#6B7280 / folder.color). Every deleted resource type now maps through RESOURCE_REGISTRY.renderTabIcon, matching mothership/home styling via var(--text-icon).

The type map is completed for folder and workspace_folder, DeletedResource.color and folder color when building the list are removed, and unused Workflow / Folder imports are dropped. ICON_CLASS adds shrink-0 for consistent layout with registry icons.

Reviewed by Cursor Bugbot for commit 3383495. Configure here.

@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR standardizes icons on the Recently Deleted settings page. The main changes are:

  • Routes every supported resource type through RESOURCE_REGISTRY.
  • Maps folders and workspace folders to their shared icon renderers.
  • Applies the platform icon-color token and non-shrinking layout class.
  • Removes unused folder-color data and direct icon imports.

Confidence Score: 5/5

This looks safe to merge.

  • Every reachable deleted-resource type maps to an existing registry entry.
  • The icon renderers accept the supplied resource shape and preserve the new layout classes.
  • The folder color change matches the stated goal of using the shared platform token.
  • No blocking issues were found in the changed code.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/settings/components/recently-deleted/recently-deleted.tsx Replaces special-case icon rendering with complete registry-backed mappings and removes obsolete color plumbing.

Reviews (1): Last reviewed commit: "fix(settings): align recently-deleted ic..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 85c3a7b into staging Jul 15, 2026
13 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/recently-deleted-icon-colors branch July 15, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant