Skip to content

fix(mothership): hide preview-block-owned triggers from copilot VFS #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 1 commit into from
Jul 14, 2026
Merged

fix(mothership): hide preview-block-owned triggers from copilot VFS #5676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 42 additions & 6 deletions apps/sim/lib/copilot/vfs/workspace-vfs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,17 @@ let staticComponentFiles: Map<string, string> | null = null
*/
const integrationPathOwners = new Map<string, Pick<BlockConfig, 'type' | 'preview'>>()

/**
* Owning block(s) for each `components/triggers/{provider}/{id}.json` file,
* recorded at build time by inverting each block's `triggers.available`.
* External-trigger paths are keyed on the trigger id + provider (not a block
* type), so — like integration paths — they need this lookup for the stamp-time
* visibility filter. A trigger can be reachable from more than one block (e.g. a
* GA block and its preview successor), so this holds an array and the trigger is
* hidden only when EVERY owning block is hidden.
*/
const triggerPathOwners = new Map<string, Array<Pick<BlockConfig, 'type' | 'preview'>>>()

/**
* Per-request visibility filter for the shared static files: hides files whose
* owning block is gated for this viewer (unrevealed preview blocks — the
Expand All @@ -168,6 +179,10 @@ function isStaticFileHidden(path: string, vis: BlockVisibilityState | null): boo
const config = BLOCK_REGISTRY[blockMatch[1]!]
return config ? isHiddenUnder(vis, config) : false
}
const triggerOwners = triggerPathOwners.get(path)
if (triggerOwners) {
return triggerOwners.length > 0 && triggerOwners.every((owner) => isHiddenUnder(vis, owner))
}
const owner = integrationPathOwners.get(path)
return owner ? isHiddenUnder(vis, owner) : false
}
Expand Down Expand Up @@ -353,6 +368,21 @@ function getStaticComponentFiles(): Map<string, string> {
files.set(`components/triggers/sim/${block.type}.json`, serializeBuiltinTriggerSchema(block))
}

// Attribute each external trigger to its owning block(s) by inverting
// `triggers.available` — the same block-visibility rules that gate a block's
// schema file then gate its triggers' schema files at stamp time.
for (const block of allBlocks) {
for (const triggerId of block.triggers?.available ?? []) {
const trigger = TRIGGER_REGISTRY[triggerId]
if (!trigger) continue
const path = `components/triggers/${trigger.provider}/${triggerId}.json`
const owners = triggerPathOwners.get(path)
const owner = { type: block.type, preview: block.preview }
if (owners) owners.push(owner)
else triggerPathOwners.set(path, [owner])
}
}

let externalTriggerCount = 0
for (const [triggerId, trigger] of Object.entries(TRIGGER_REGISTRY)) {
const path = `components/triggers/${trigger.provider}/${triggerId}.json`
Expand All @@ -373,12 +403,18 @@ function getStaticComponentFiles(): Map<string, string> {
provider: 'sim',
description: b.description,
})),
Object.entries(TRIGGER_REGISTRY).map(([id, t]) => ({
id,
name: t.name,
provider: t.provider,
description: t.description,
}))
// Same for external triggers: a trigger owned solely by preview blocks is
// hidden under the null (no-viewer) state this shared file is built with.
Object.entries(TRIGGER_REGISTRY)
.filter(
([id, t]) => !isStaticFileHidden(`components/triggers/${t.provider}/${id}.json`, null)

@greptile-apps greptile-apps Bot Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Overview Drops Revealed Triggers

When a viewer has a preview block revealed, its trigger schema file can pass the stamp-time visibility check, but triggers.md was already built once with null visibility and permanently filtered that trigger out. That leaves the overview incomplete for revealed-preview viewers, so the copilot can see the schema path but not discover the trigger from the trigger catalog.

@TheodoreSpeaks TheodoreSpeaks Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sim admin only will see this. Will fix in a followup.

)
.map(([id, t]) => ({
id,
name: t.name,
provider: t.provider,
description: t.description,
}))
)
)

Expand Down
Loading