The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 8, 2026 3:37am

PR Summary

Medium Risk
Changes workflow room join/rejoin behavior on session errors and navigation, which can cause clients to attempt joining a workflow that was just deleted or referenced by a stale URL. Impact is limited to realtime collaboration UX but could reintroduce a previously fixed edge case.

Overview
Reverts the recent client-side safeguard that prevented the socket from rejoining/joining a workflow room immediately after receiving workflow-deleted.

This removes deletedWorkflowIdRef tracking and associated checks, so operation-forbidden (session expiration) and the URL-driven join effect will now attempt to join-workflow whenever a workflowId is present and the client isn’t already rejoining.

^{Reviewed by Cursor Bugbot for commit 95e02c2. Configure here.}

Greptile Summary

This PR reverts #4004 ("fix(sockets): joining currently deleted workflow"), removing the guard that prevented the socket client from attempting to rejoin a workflow that was just deleted. No explanation is provided for why the fix is being reverted.

Key changes:

• Removes deletedWorkflowIdRef ref that tracked the last deleted workflow's ID
• Removes the assignment of deletedWorkflowIdRef.current in the workflow-deleted event handler
• Removes the deletedWorkflowIdRef.current !== workflowId guard in the SESSION_ERROR / operation-forbidden path, which means a session-expiry rejoin will now target a deleted workflow if the URL still holds its ID
• Removes the guard in the urlWorkflowId-change useEffect that skipped joining a workflow that had just been deleted but whose ID still appeared in the URL

The revert re-introduces the race condition that #4004 was specifically addressing: after a workflow-deleted event clears currentWorkflowId, there is a window where urlWorkflowId still references the deleted workflow (while router.push() propagates). During that window both the join-workflow useEffect and the SESSION_ERROR handler will attempt to emit join-workflow for a workflow that no longer exists on the server.

Confidence Score: 3/5

Not safe to merge without explanation — reintroduces a known race condition where the client attempts to join a deleted workflow room

The revert deliberately removes a targeted guard (deletedWorkflowIdRef) that prevented rejoining a deleted workflow during the URL-propagation window. This is a present defect on the changed path: any time a workflow is deleted, there is a real timing window during which both the useEffect and the SESSION_ERROR handler will emit join-workflow for a room that no longer exists. The PR description provides no context for why the fix is being reverted, making it impossible to evaluate whether an alternative approach is planned. Until the motivation is clear and a replacement guard is in place, this scores P1.

apps/sim/app/workspace/providers/socket-provider.tsx — the deleted-workflow guard was the only protection against the rejoin race condition

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant Server
    participant Socket as SocketProvider
    participant Router as Next.js Router

    Server->>Socket: workflow-deleted { workflowId }
    Socket->>Socket: setCurrentWorkflowId(null)
    Note over Router: router.push() in progress — URL still = deleted workflowId

    alt SESSION_ERROR fires during propagation window
        Server->>Socket: operation-forbidden { type: SESSION_ERROR }
        Socket->>Socket: workflowId = urlWorkflowIdRef.current (= deleted ID)
        Socket->>Server: join-workflow { workflowId: deletedId } ❌
    end

    alt useEffect fires during propagation window
        Note over Socket: currentWorkflowId=null, urlWorkflowId=deletedId → not equal
        Socket->>Server: join-workflow { workflowId: deletedId } ❌
    end

    Router-->>Socket: URL updated to new workflowId
    Note over Socket: Race window closes

_{Reviews (1): Last reviewed commit: "Revert "fix(sockets): joining currently ..." | Re-trigger Greptile}