Skip to content

improvement(home): position @ mention popup at caret and fix icon consistency #3831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 3 commits into from
Mar 28, 2026
+224 −155
Merged

improvement(home): position @ mention popup at caret and fix icon consistency #3831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68986c3
improvement(home): position @ mention popup at caret and fix icon con…
waleedlatif1 Mar 28, 2026
617983e
fix(home): pin mirror div to document origin and guard button anchor
waleedlatif1 Mar 28, 2026
120bd88
chore(auth): restore hybrid.ts to staging
waleedlatif1 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...aceId]/home/components/mothership-view/components/resource-registry/resource-registry.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function WorkflowDropdownItem({ item }: DropdownItemRenderProps) {
return (
<>
<div
className='mr-[0px] h-[14px] w-[14px] flex-shrink-0 rounded-[3px] border-[2px]'
className='h-[14px] w-[14px] flex-shrink-0 rounded-[3px] border-[2px]'
style={{
backgroundColor: color,
borderColor: `${color}60`,
Expand All @@ -72,7 +72,16 @@ function FileDropdownItem({ item }: DropdownItemRenderProps) {
const DocIcon = getDocumentIcon('', item.name)
return (
<>
<DocIcon className='mr-2 h-[14px] w-[14px] text-[var(--text-icon)]' />
<DocIcon className='h-[14px] w-[14px] flex-shrink-0 text-[var(--text-icon)]' />
<span className='truncate'>{item.name}</span>
</>
)
}

function IconDropdownItem({ item, icon: Icon }: DropdownItemRenderProps & { icon: ElementType }) {
return (
<>
<Icon className='h-[14px] w-[14px] flex-shrink-0 text-[var(--text-icon)]' />
<span className='truncate'>{item.name}</span>
</>
)
Expand Down Expand Up @@ -104,7 +113,7 @@ export const RESOURCE_REGISTRY: Record<MothershipResourceType, ResourceTypeConfi
renderTabIcon: (_resource, className) => (
<TableIcon className={cn(className, 'text-[var(--text-icon)]')} />
),
renderDropdownItem: (props) => <DefaultDropdownItem {...props} />,
renderDropdownItem: (props) => <IconDropdownItem {...props} icon={TableIcon} />,
},
file: {
type: 'file',
Expand All @@ -123,7 +132,7 @@ export const RESOURCE_REGISTRY: Record<MothershipResourceType, ResourceTypeConfi
renderTabIcon: (_resource, className) => (
<Database className={cn(className, 'text-[var(--text-icon)]')} />
),
renderDropdownItem: (props) => <DefaultDropdownItem {...props} />,
renderDropdownItem: (props) => <IconDropdownItem {...props} icon={Database} />,
},
} as const

Expand Down
2 changes: 1 addition & 1 deletion apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export type WindowWithSpeech = Window & {
}

export interface PlusMenuHandle {
open: () => void
open: (anchor?: { left: number; top: number }) => void
}

export const TEXTAREA_BASE_CLASSES = cn(
Expand Down
Loading
Loading