Greptile Overview

Greptile Summary

Fixes React crashes when workflow outputs return structured objects by introducing a robust formatting utility that safely converts various output types to displayable strings. Replaces inline JSON.stringify calls in chat components with deep object traversal that intelligently extracts text content from nested structures. Includes comprehensive unit tests covering edge cases like circular references, binary data, and common LLM response formats.

Confidence Score: 3/5

• Generally safe with minor implementation issues that should be addressed
• The PR successfully solves the object rendering crash issue with comprehensive error handling and extensive test coverage. However, several implementation concerns warrant attention: (1) unused seenObjects variable indicates incomplete cleanup, (2) array joining with newlines may cause unexpected vertical layout in chat UI, (3) aggressive whitespace normalization could break formatted content like code snippets, and (4) for...in usage is less efficient than modern alternatives. These are style and UX concerns rather than critical bugs, but they could impact display quality and code maintainability.
• apps/sim/lib/core/utils/format-output.ts needs attention for unused variables, whitespace handling, and array formatting behavior

Important Files Changed

File Analysis

Sequence Diagram

sequenceDiagram
    participant User
    participant ChatMessage
    participant FormatUtil as format-output.ts
    participant DeepExtract as deepExtractText()
    participant SafeStringify as safeStringify()

    User->>ChatMessage: Render message with object content
    ChatMessage->>FormatUtil: formatOutputForChat(content)
    FormatUtil->>FormatUtil: extractContent(item)
    
    alt Object with text field
        FormatUtil->>DeepExtract: deepExtractText(obj)
        DeepExtract->>DeepExtract: Search TEXT_FIELD_NAMES
        DeepExtract->>DeepExtract: Recursive traversal (max depth 10)
        DeepExtract-->>FormatUtil: Return extracted text
        FormatUtil->>FormatUtil: Clean whitespace & truncate
        FormatUtil-->>ChatMessage: Formatted string
    else Array
        FormatUtil->>FormatUtil: Map extractContent over items
        FormatUtil->>FormatUtil: Join with newline
        FormatUtil-->>ChatMessage: Joined string
    else Fallback to JSON
        FormatUtil->>SafeStringify: safeStringify(obj)
        SafeStringify->>SafeStringify: Handle circular refs
        SafeStringify-->>FormatUtil: JSON string
        FormatUtil->>FormatUtil: Wrap in code block (workflow mode)
        FormatUtil-->>ChatMessage: Formatted JSON
    end
    
    ChatMessage->>User: Display formatted text