fix(custom-bot-slack): dependsOn incorrectly set for bot_token#2214
Merged
icecrasher321 merged 3 commits intostagingfrom Dec 5, 2025
Merged
fix(custom-bot-slack): dependsOn incorrectly set for bot_token#2214icecrasher321 merged 3 commits intostagingfrom
icecrasher321 merged 3 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes a bug where the Slack channel selector was incorrectly disabled when using Custom Bot authentication (bot token) instead of OAuth. The fix introduces a more flexible dependency system that supports both AND (
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant SlackBlock
participant ChannelSelector
participant useDependsOnGate
participant parseDependsOn
User->>SlackBlock: Select "Custom Bot" auth method
User->>SlackBlock: Enter bot token
SlackBlock->>ChannelSelector: Render with dependsOn config
ChannelSelector->>useDependsOnGate: Check dependencies
useDependsOnGate->>parseDependsOn: Parse {all: ['authMethod'], any: ['credential', 'botToken']}
parseDependsOn-->>useDependsOnGate: allFields=['authMethod'], anyFields=['credential', 'botToken']
useDependsOnGate->>useDependsOnGate: Check allFields satisfied (authMethod ✓)
useDependsOnGate->>useDependsOnGate: Check anyFields satisfied (botToken ✓)
useDependsOnGate-->>ChannelSelector: depsSatisfied=true, blocked=false
ChannelSelector-->>User: Channel selector enabled
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist