Greptile Summary

This PR fixes a critical bug in the OTP (One-Time Password) verification system for development environments. The main issue was that the verification skip logic wasn't working correctly in local development and Docker setups without email services configured.

The changes introduce a more sophisticated email service detection mechanism by adding a hasEmailService() function to the mailer module that checks for both Resend and Azure Communication Services availability. This replaces the previous simple environment variable check that only looked for Resend API keys.

The core fix updates the verification logic from checking only production status to checking both production status AND email service availability. The new logic implements three distinct behaviors:

1. Local development without email service = no verification required
2. Production deployment = verification always required
3. Any setup with email service = verification required (secure default)

Key technical changes include:

• Adding hasEmailService() function in apps/sim/lib/email/mailer.ts that returns true if either Resend or Azure email clients are configured
• Updating the auth system in apps/sim/lib/auth.ts to use requireEmailVerification: isProd && hasEmailService() instead of just checking production status
• Refactoring the verification hook from hasResendKey to hasEmailService parameter with updated skip logic !isProduction && !hasEmailService
• Setting explicit NODE_ENV values in Docker compose files for proper environment detection
• Adding fallback logging for development environments to display OTP codes in console when no email service is configured

The changes maintain security by ensuring verification is never skipped in production while providing a smooth development experience when email services aren't configured locally.

Confidence score: 4/5

• This PR addresses a legitimate bug with well-structured fixes across multiple related files
• The logic change from OR to AND condition (!isProduction && !hasEmailService) properly fixes the security vulnerability where verification could be bypassed in production
• The centralized email service detection and consistent parameter renaming improve code maintainability and clarity across the verification system

_{7 files reviewed, 1 comment}

_{Edit Code Review Bot Settings | Greptile}