Repository navigation
Expand file tree
/
Copy pathrefresh.test.ts
More file actions
323 lines (311 loc) · 10.8 KB
/
Copy pathrefresh.test.ts
File metadata and controls
323 lines (311 loc) · 10.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
import { type ChildProcess, execFileSync, fork } from 'node:child_process'
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
import { createServer, type ServerResponse } from 'node:http'
import type { AddressInfo } from 'node:net'
import { tmpdir } from 'node:os'
import { join } from 'node:path'
import { fileURLToPath } from 'node:url'
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, vi } from 'vitest'
import {
readStoredCredential,
writeConfigProfile,
writeCredentialsProfile,
} from '../config/profile'
import { refreshStoredOAuth } from './refresh'
const PROFILE = { name: 'default', endpoint: 'https://sim.test', authProfile: 'default' }
const OAUTH_CONTEXT = {
issuer: 'https://sim.test/api/auth',
loginId: 'login-1',
scope: 'offline_access api:read',
}
function reply(status: number, body: unknown): Response {
return new Response(JSON.stringify(body), { status }) as Response
}
let dir: string
beforeEach(() => {
dir = mkdtempSync(join(tmpdir(), 'sim-cli-refresh-'))
vi.stubEnv('SIM_CONFIG_DIR', dir)
})
afterEach(() => {
rmSync(dir, { recursive: true, force: true })
})
describe('refreshStoredOAuth', () => {
it('rotates the pair on the server and persists what came back', async () => {
writeCredentialsProfile('default', {
kind: 'oauth',
oauth: {
accessToken: 'old-access',
refreshToken: 'old-refresh',
expiresAt: 1,
...OAUTH_CONTEXT,
},
})
const fetchMock = vi.fn(async () =>
reply(200, { access_token: 'new-access', refresh_token: 'new-refresh', expires_in: 3600 })
)
vi.stubGlobal('fetch', fetchMock)
const next = await refreshStoredOAuth(PROFILE, {
accessToken: 'old-access',
refreshToken: 'old-refresh',
expiresAt: 1,
...OAUTH_CONTEXT,
})
expect(next.refreshToken).toBe('new-refresh')
const [, init] = fetchMock.mock.calls[0] as unknown as [string, RequestInit]
expect(Object.fromEntries(new URLSearchParams(String(init.body)))).toMatchObject({
grant_type: 'refresh_token',
refresh_token: 'old-refresh',
})
expect(readStoredCredential('default')).toEqual({
kind: 'oauth',
oauth: {
accessToken: 'new-access',
refreshToken: 'new-refresh',
expiresAt: next.expiresAt,
...OAUTH_CONTEXT,
},
})
})
/**
* The rotation race: a refresh token presented twice revokes the whole
* session server-side. A process that took the lock second must find the
* winner's tokens on disk and use them instead of presenting the dead one.
*/
it('adopts a rotation another process already wrote instead of presenting the dead token', async () => {
writeCredentialsProfile('default', {
kind: 'oauth',
oauth: {
accessToken: 'winner-access',
refreshToken: 'winner-refresh',
expiresAt: 99,
...OAUTH_CONTEXT,
},
})
const fetchMock = vi.fn()
vi.stubGlobal('fetch', fetchMock)
const next = await refreshStoredOAuth(PROFILE, {
accessToken: 'stale-access',
refreshToken: 'stale-refresh',
expiresAt: 1,
...OAUTH_CONTEXT,
})
expect(next.refreshToken).toBe('winner-refresh')
expect(fetchMock).not.toHaveBeenCalled()
})
})
describe('across processes', () => {
interface WorkerResult {
refreshToken?: string
error?: string
}
function deferred<T>() {
let resolve!: (value: T) => void
let reject!: (reason: Error) => void
const promise = new Promise<T>((yes, no) => {
resolve = yes
reject = no
})
void promise.catch(() => undefined)
return { promise, resolve, reject }
}
let buildDir: string
let workerPath: string
let configDir: string
const children = new Set<ChildProcess>()
beforeAll(() => {
buildDir = mkdtempSync(join(tmpdir(), 'sim-oauth-process-build-'))
const source = join(buildDir, 'worker.ts')
const modulePath = (path: string) =>
JSON.stringify(fileURLToPath(new URL(path, import.meta.url)))
writeFileSync(
source,
`
import { readStoredCredential } from ${modulePath('../config/profile.ts')}
import { refreshStoredOAuth } from ${modulePath('./refresh.ts')}
import { logoutCommand } from ${modulePath('../commands/auth.ts')}
const current = readStoredCredential('default').oauth
process.once('message', async () => {
try {
if (process.argv[2] === 'logout') {
await logoutCommand().parseAsync([], { from: 'user' })
process.send({})
} else {
const next = await refreshStoredOAuth({ name: 'default', authProfile: 'default', endpoint: process.env.TEST_ENDPOINT }, current)
process.send({ refreshToken: next.refreshToken })
}
} catch (error) { process.send({ error: error.message }) }
process.disconnect()
})
process.send('ready')
`
)
mkdirSync(join(buildDir, 'dist'))
writeFileSync(join(buildDir, 'package.json'), JSON.stringify({ version: '2.1.2' }))
workerPath = join(buildDir, 'dist', 'worker.mjs')
execFileSync(
'bun',
['build', source, '--target=node', '--format=esm', '--outfile', workerPath],
{
stdio: 'pipe',
}
)
})
afterAll(() => rmSync(buildDir, { recursive: true, force: true }))
beforeEach(() => {
configDir = mkdtempSync(join(tmpdir(), 'sim-oauth-process-config-'))
vi.stubEnv('SIM_CONFIG_DIR', configDir)
vi.stubEnv('SIM_CONFIG_FILE', undefined)
vi.stubEnv('SIM_CREDENTIALS_FILE', undefined)
})
afterEach(() => {
for (const child of children) child.kill('SIGKILL')
children.clear()
rmSync(configDir, { recursive: true, force: true })
})
function startWorker(endpoint: string, mode: 'refresh' | 'logout') {
const ready = deferred<void>()
const result = deferred<WorkerResult>()
const env: NodeJS.ProcessEnv = {
...process.env,
SIM_CONFIG_DIR: configDir,
TEST_ENDPOINT: endpoint,
}
for (const key of Object.keys(env)) {
if (key.startsWith('SIM_') && key !== 'SIM_CONFIG_DIR') delete env[key]
}
const child = fork(workerPath, [mode], { env, stdio: ['ignore', 'ignore', 'pipe', 'ipc'] })
children.add(child)
let output: WorkerResult | undefined
let stderr = ''
child.stderr?.on('data', (chunk: Buffer) => {
stderr += chunk.toString()
})
child.on('message', (message: unknown) => {
if (message === 'ready') ready.resolve()
else output = message as WorkerResult
})
child.once('error', (error) => {
ready.reject(error)
result.reject(error)
})
child.once('exit', (code) => {
children.delete(child)
if (code === 0 && output) result.resolve(output)
else {
const error = new Error(`OAuth worker exited ${code}: ${stderr}`)
ready.reject(error)
result.reject(error)
}
})
return { ready: ready.promise, result: result.promise, run: () => child.send('run') }
}
async function withOAuthServer(
run: (context: {
endpoint: string
requests: string[]
firstRequest: Promise<void>
release: () => void
}) => Promise<void>
) {
const requests: string[] = []
const firstRequest = deferred<void>()
let heldResponse: ServerResponse | undefined
const respond = (response: ServerResponse) => {
response.writeHead(200, { 'content-type': 'application/json' })
response.end(
JSON.stringify({
access_token: 'new-access',
refresh_token: 'new-refresh',
expires_in: 3600,
scope: 'offline_access api:read',
})
)
}
const server = createServer((request, response) => {
const chunks: Buffer[] = []
request.on('data', (chunk: Buffer) => chunks.push(chunk))
request.on('end', () => {
const body = new URLSearchParams(Buffer.concat(chunks).toString())
requests.push(`${request.url}:${body.get('refresh_token') ?? body.get('token')}`)
if (requests.length === 1) {
heldResponse = response
firstRequest.resolve()
} else respond(response)
})
})
await new Promise<void>((resolve) => server.listen(0, '127.0.0.1', resolve))
const endpoint = `http://127.0.0.1:${(server.address() as AddressInfo).port}`
writeConfigProfile('default', { endpoint })
writeCredentialsProfile('default', {
kind: 'oauth',
oauth: {
accessToken: 'old-access',
refreshToken: 'old-refresh',
expiresAt: 1,
issuer: `${endpoint}/api/auth`,
loginId: 'process-test',
scope: 'offline_access api:read',
},
})
try {
await run({
endpoint,
requests,
firstRequest: firstRequest.promise,
release: () => {
if (heldResponse) respond(heldResponse)
},
})
} finally {
server.closeAllConnections()
await new Promise<void>((resolve) => server.close(() => resolve()))
}
}
it('two independent processes share one refresh and persist the same rotation', async () => {
await withOAuthServer(async ({ endpoint, requests, firstRequest, release }) => {
const first = startWorker(endpoint, 'refresh')
const second = startWorker(endpoint, 'refresh')
await Promise.all([first.ready, second.ready])
first.run()
await firstRequest
second.run()
release()
expect(await Promise.all([first.result, second.result])).toEqual([
{ refreshToken: 'new-refresh' },
{ refreshToken: 'new-refresh' },
])
expect(requests).toEqual(['/api/auth/oauth2/token:old-refresh'])
expect(readStoredCredential('default')).toMatchObject({
oauth: { refreshToken: 'new-refresh' },
})
})
}, 15000)
it.each(['refresh', 'logout'] as const)(
'serializes logout with refresh when %s holds the lock first',
async (firstMode) => {
await withOAuthServer(async ({ endpoint, requests, firstRequest, release }) => {
const first = startWorker(endpoint, firstMode)
const second = startWorker(endpoint, firstMode === 'refresh' ? 'logout' : 'refresh')
await Promise.all([first.ready, second.ready])
first.run()
await firstRequest
second.run()
release()
const results = await Promise.all([first.result, second.result])
expect(readStoredCredential('default')).toBeNull()
if (firstMode === 'refresh') {
expect(results).toEqual([{ refreshToken: 'new-refresh' }, {}])
expect(requests).toEqual([
'/api/auth/oauth2/token:old-refresh',
'/api/auth/oauth2/revoke:new-refresh',
])
} else {
expect(results[0]).toEqual({})
expect(results[1].error).toContain('stored login changed')
expect(requests).toEqual(['/api/auth/oauth2/revoke:old-refresh'])
}
})
},
15000
)
})