core, android, desktop: do not accept contact request twice - #7345
Draft
Narasimha-sc wants to merge 3 commits into
Draft
core, android, desktop: do not accept contact request twice#7345Narasimha-sc wants to merge 3 commits into
Narasimha-sc wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepting an already accepted contact request fails with
CMD PROHIBITED SEInvitationNotFound, as reported after accepting from a notification and then accepting again in the chat. The contact request is not deleted when it is accepted (deleteContactRequestRecwas removed from the accept path in #6011), so a repeat accept passes all chat checks and reaches the agent with an invitation that is already used. This rejects accepting a request whose contact connection was already created, and stops offering to accept a request while it is being accepted in another view.Justification, rejected alternatives and known gap: plans/2026-08-05-fix-double-accept-contact-request.md