Two small improvements #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular Dutch country names often contain special characters and we don't want to use a particular encoding.
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
========================================
Coverage 0.00% 0.00%
- Complexity 78 79 +1
========================================
Files 1 1
Lines 188 189 +1
========================================
- Misses 188 189 +1 |
tvdijen
reviewed
Jun 9, 2020
tvdijen
requested changes
Jun 9, 2020
Member
tvdijen
left a comment
tvdijen
left a comment
There was a problem hiding this comment.
Disagree with the diacritic chars solution, but thumbs up on the rest!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small improvements:
isset()instead if!is_nulland adding an explicit test usingarray_key_exists(preventsundefined indexwarningsrawfilter to properly display names such as België and Tsjechië