Skip to content

Conversation

@thijskh
Copy link
Member

@thijskh thijskh commented Sep 24, 2021

  • main() does not return response but void because it derives from \SimpleSAML\XHTML\IdpDisco.php which already outputs the template
  • also removed references to shib13-idp-remote
  • tests may be extended at some point
  • name disco.php with php extension kept for path since it may be in local/remote configs.

@thijskh thijskh requested a review from tvdijen September 24, 2021 19:31
@thijskh thijskh changed the title Inital controller Initial controller Sep 26, 2021
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #11 (ee1dabb) into master (12ce739) will increase coverage by 7.63%.
The diff coverage is 81.48%.

❗ Current head ee1dabb differs from pull request most recent head 97fb157. Consider uploading reports for the commit 97fb157 to get more accurate results

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
+ Coverage     22.65%   30.28%   +7.63%     
- Complexity       75       82       +7     
============================================
  Files             1        2       +1     
  Lines           181      208      +27     
============================================
+ Hits             41       63      +22     
- Misses          140      145       +5     

@thijskh thijskh merged commit 9dd436b into master Sep 26, 2021
@thijskh thijskh deleted the controller branch September 26, 2021 16:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants