Define "errortitle" and "errordescr" params #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thijskh
requested changes
Dec 9, 2020
| $t->data['errordescr'] = $t->data['errorcodes'][$t->data['errorcode']]; | ||
| } else { | ||
| $t->data['errordescr'] = $t->data['errorcode']; | ||
| } |
Member
There was a problem hiding this comment.
This is the result of refactoring towards twig templates that was incomplete. To fully clean it up I propose the following:
- Do not set
errorcodeanderrorcodesas template variables but just as local variables and use those in the code in the added lines above. - Change the
ifcondition in the twig template to test for presence oferrordescr.
thijskh
approved these changes
Dec 10, 2020
Member
|
Thanks! |
Member
|
Does this require backporting to the 0.9 branch? |
Author
|
The problem exists in 0.9. Btw. I've just realized my fault in loading error info. Instead of this: I should do something like this (+ null checks etc.): I'll fix it soon. |
Member
|
In 0.9 the problem exists only in the new templates (not used by default so probably therefore not detected). Fix for 0.9 will need to consider to keep old templates working aswell. |
Member
|
Ack, will wait for the final fix and then port it to 0.9 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplesamlphp-module-authX509/templates/X509error.twigcontains references to errortitle and errordescr parameters. However they both are undefined. It should be in the method authFailed in:simplesamlphp-module-authX509/lib/Auth/Source/X509userCert.php
Line 87 in 3fcb6a0
This pull request addresses this issue by putting an error code and a corresponding error message if available.