Update UNC path handling #2591
Open
Update UNC path handling #2591
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ``` \\some-pc\some-share\some.key ``` Should result in ``` var_dump($ret); string(29) "//some-pc/some-share/some.key" ``` Which according to simplesamlphp#2586 should be able to be loaded. I only have a partial php win env so it needs verification against a real SSP install.
Member
|
If this works, we should capture this case in a unit test |
Contributor
Author
|
I don't know if folks are running the httpd build for win most or something else these days. From my perspective apache makes it easier if that is commonish. I guess if I installed httpd at some stage and maybe set it up to rsync the code over to that box it would perhaps help with win testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
Should result in
Which according to
#2586 should be able to be loaded.
I only have a partial php win env so it needs verification against a real SSP install.