Skip to content

BUGFIX: http-getselfurl-robust-path-and-query #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monkeyiq merged 2 commits into from
Feb 5, 2026
+83 −12
Merged

BUGFIX: http-getselfurl-robust-path-and-query #2589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b816fd
Improve HTTP::getSelfURL() path detection and URL reconstruction
ioigoume Jan 29, 2026
3a5cbf6
Revert reconstruction of URL from parts when REQUEST_URI can be used.…
ioigoume Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 33 additions & 12 deletions src/SimpleSAML/Utils/HTTP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,12 +785,19 @@ public function getSelfURL(): string
$cur_path = realpath($_SERVER['SCRIPT_FILENAME']);
// make sure we got a string from realpath()
$cur_path = is_string($cur_path) ? $cur_path : '';

// find the path to the current script relative to the public/ directory of SimpleSAMLphp
$rel_path = str_replace($baseDir . 'public' . DIRECTORY_SEPARATOR, '', $cur_path);
// convert that relative path to an HTTP query

$url_path = str_replace(DIRECTORY_SEPARATOR, '/', $rel_path);
// find where the relative path starts in the current request URI
$uri_pos = (!empty($url_path)) ? strpos($_SERVER['REQUEST_URI'] ?? '', $url_path) : false;

$requestUri = (string)($_SERVER['REQUEST_URI'] ?? '');
$requestPath = (string)parse_url($requestUri, PHP_URL_PATH);
$requestQuery = (string)parse_url($requestUri, PHP_URL_QUERY);
$requestFragment = (string)parse_url($requestUri, PHP_URL_FRAGMENT);

// Match script-relative path only against the path part of the request
$uri_pos = (!empty($url_path)) ? strpos($requestPath, $url_path) : false;

if ($cur_path == $rel_path || $uri_pos === false) {
/*
Expand All @@ -799,12 +806,13 @@ public function getSelfURL(): string
* - $_SERVER['SCRIPT_FILENAME'] points to a script that doesn't exist. E.g. functional testing. In this
* case, realpath() returns false and str_replace an empty string, so we compare them loosely.
*
* - The URI requested does not belong to a script in the public/ directory of SimpleSAMLphp. In that case,
* removing SimpleSAMLphp's base dir from the current path yields the same path, so $cur_path and
* - The script is not located under the public/ directory of SimpleSAMLphp. In that case, removing
* SimpleSAMLphp's base dir and public/ from the current path yields the same path, so $cur_path and
* $rel_path are equal.
*
* - The request URI does not match the current script. Even if the current script is located in the
* public/ directory of SimpleSAMLphp, the URI does not contain its relative path, and $uri_pos is false.
* - The request path does not match the current script. Even if the current script is located in the
* public/ directory of SimpleSAMLphp, the request path (without query string) does not contain its
* relative path, and $uri_pos is false.
*
* It doesn't matter which one of those cases we have. We just know we can't apply our base URL to the
* current URI, so we need to build it back from the PHP environment, unless we have a base URL specified
Expand All @@ -814,20 +822,33 @@ public function getSelfURL(): string
$appurl = ($appcfg !== null) ? $appcfg->getOptionalString('baseURL', null) : null;

if (!empty($appurl)) {
$protocol = parse_url($appurl, PHP_URL_SCHEME);
$hostname = parse_url($appurl, PHP_URL_HOST);
$port = parse_url($appurl, PHP_URL_PORT);
$port = !empty($port) ? ':' . $port : '';
$protocol = (string)parse_url($appurl, PHP_URL_SCHEME);
$hostname = (string)parse_url($appurl, PHP_URL_HOST);
$portNum = parse_url($appurl, PHP_URL_PORT);
$port = !empty($portNum) ? ':' . $portNum : '';
} else {
// no base URL specified for app, just use the current URL
$protocol = $this->getServerHTTPS() ? 'https' : 'http';
$hostname = $this->getServerHost();
$port = $this->getServerPort();
}

return $protocol . '://' . $hostname . $port . $_SERVER['REQUEST_URI'];
}

return $this->getBaseURL() . $url_path . substr($_SERVER['REQUEST_URI'], $uri_pos + strlen($url_path));
// Normal case: baseURL + script-relative path + remaining path, plus query if present
$suffix = substr($requestPath, $uri_pos + strlen($url_path));
$url = $this->getBaseURL() . $url_path . $suffix;

if ($requestQuery !== '') {
$url .= '?' . $requestQuery;
}

if ($requestFragment !== '') {
$url .= '#' . $requestFragment;
}

return $url;
}


Expand Down
50 changes: 50 additions & 0 deletions tests/src/SimpleSAML/Utils/HTTPTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,4 +757,54 @@ public static function slowPostDelayProvider(): array
'positive config 10000 => 10000' => [10000, 10000],
];
}

/**
* Ensure getSelfURL() returns the externally visible URL when SimpleSAMLphp
* is reached via a rewritten path (e.g. /cas/login -> /simplesaml/module.php/...),
* and the internal script name (module.php) appears only in the query string.
*
* This simulates an Apache mod_rewrite rule like:
* RewriteRule ^/cas/login(.*) /${SSP_APACHE_ALIAS}module.php/casserver/login.php$1 [PT]
*
* In this scenario the public URL is /cas/login?... while the actual script is
* public/module.php.
*/
public function testGetSelfURLWithRewrittenCasLogin(): void
{
$originalServer = $_SERVER;

$httpUtils = new Utils\HTTP();

$cfg = Configuration::loadFromArray([
'baseurlpath' => 'https://tr-monitor-okta2.qa.athena-institute.net/simplesaml/',
], '[ARRAY]', 'simplesaml');
$baseDir = $cfg->getBaseDir();

$_SERVER = [
'HTTPS' => 'on',
'HTTP_HOST' => 'tr-monitor-okta2.qa.athena-institute.net',
'SERVER_NAME' => 'tr-monitor-okta2.qa.athena-institute.net',
'SERVER_PORT' => 443,
'SCRIPT_URI' => 'https://tr-monitor-okta2.qa.athena-institute.net/cas/login',
'SCRIPT_NAME' => '/module.php',
'SCRIPT_FILENAME' => $baseDir . 'public' . DIRECTORY_SEPARATOR . 'module.php',
'PATH_TRANSLATED' => $baseDir . 'public' . DIRECTORY_SEPARATOR . 'casserver/login.php',
'PHP_SELF' => '/module.php/casserver/login.php',
'QUERY_STRING' => 'service='
. 'https%3A%2F%2Fcas-test-bridge.bridge.qa.cirrusidentity.com%2Fmodule.php%2Fcas%2Flinkback.php'
. '%3FstateId%3D_somestate',
'REQUEST_URI' => '/cas/login?service='
. 'https%3A%2F%2Fcas-test-bridge.bridge.qa.cirrusidentity.com%2Fmodule.php%2Fcas%2Flinkback.php'
. '%3FstateId%3D_somestate',
];

$expected = 'https://tr-monitor-okta2.qa.athena-institute.net'
. '/cas/login'
. '?service=https%3A%2F%2Fcas-test-bridge.bridge.qa.cirrusidentity.com%2Fmodule.php%2Fcas%2Flinkback.php'
. '%3FstateId%3D_somestate';

$this->assertSame($expected, $httpUtils->getSelfURL());

$_SERVER = $originalServer;
}
}
Loading