Record values from RequestedAttributes (2.5.x) #2582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkeyiq
approved these changes
Jan 13, 2026
Contributor
|
I'll be checking out the CI for 2.5 soon |
Member
|
It's gonna need:
|
tvdijen
force-pushed
the
patch-attributevalues-2.5
branch
from
c18bfbc to
c5c4ead
Compare
Member
|
Forget my earlier comment. I need to finish some work on the xml-libraries and update the 2.5-branch. |
Contributor
|
cool |
Contributor
|
I am happy to fix things in the CI that are needed for this. |
monkeyiq
merged commit 26d17d0
into
simplesamlphp:simplesamlphp-2.5
12 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #2581 to the simplesamlphp-2.5 branch so that it makes it into the next release.
This version tests cleanly with PHPUnit, and also in a deployed SimpleSAMLphp (2.4.4) instance.
It fixes simplesamlphp/simplesamlphp-module-metarefresh#51