store.redis.tls should apply to sentinels #2557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation in config.php.dist says
However, that's not what actually happens. We can connect to TLS-enabled sentinels using tls://, but
if they return a TLS-enabled master, then we still try tcp:// rather than tls:// when connecting. That causes an exception to be thrown:
This completes the configuration started in #1828 by making it possible to use a wholly TLS-enabled Redis setup with sentinels.