Better handle win paths here by splitting on dir separator #2431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $matches[0] should not be using the DIRECTORY_SEPARATOR since it is working on a string that is created using '/' and the REQUEST_URI. This relates to simplesamlphp#2424
tvdijen
approved these changes
May 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplesamlphp-2.4 #2431 +/- ##
=======================================================
- Coverage 45.21% 0 -45.22%
=======================================================
Files 165 0 -165
Lines 13248 0 -13248
=======================================================
- Hits 5990 0 -5990
+ Misses 7258 0 -7258 🚀 New features to boost your workflow:
|
monkeyiq
added a commit
that referenced
this pull request
May 20, 2025
* Better handle win paths here by splitting on dir separator The $matches[0] should not be using the DIRECTORY_SEPARATOR since it is working on a string that is created using '/' and the REQUEST_URI. This relates to #2424 * If we are on win then we need to pass in paths like we are * lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $matches[0] should not be using the DIRECTORY_SEPARATOR since it is working on a string that is created using '/' and the REQUEST_URI.
This relates to #2424