i18n warn if a module has an unexpected domain in its po file.#2408
Merged
monkeyiq merged 1 commit intosimplesamlphp:simplesamlphp-2.4from Mar 21, 2025
Conversation
This is a follow up to the theme domain handling update from simplesamlphp#2384 If you copy the translations for an existing theme or module and forget to change the domain setting in the po file then it might not be found by SSP. With this warning message you will at least have some indication as to why this might have happened.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplesamlphp-2.4 #2408 +/- ##
=======================================================
- Coverage 45.23% 45.21% -0.02%
- Complexity 3953 3954 +1
=======================================================
Files 165 165
Lines 13241 13248 +7
=======================================================
+ Hits 5989 5990 +1
- Misses 7252 7258 +6 🚀 New features to boost your workflow:
|
tvdijen
approved these changes
Mar 19, 2025
tvdijen
approved these changes
Mar 20, 2025
monkeyiq
added a commit
that referenced
this pull request
Mar 21, 2025
This is a follow up to the theme domain handling update from #2384 If you copy the translations for an existing theme or module and forget to change the domain setting in the po file then it might not be found by SSP. With this warning message you will at least have some indication as to why this might have happened.
monkeyiq
added a commit
that referenced
this pull request
Mar 21, 2025
This is a follow up to the theme domain handling update from #2384 If you copy the translations for an existing theme or module and forget to change the domain setting in the po file then it might not be found by SSP. With this warning message you will at least have some indication as to why this might have happened.
Contributor
Author
|
I picked this forward to master and back to 2.3. Since it is a warning it should be fine as a bug fix and may help folks who are not getting the translations they are expecting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the theme domain handling update from #2384
If you copy the translations for an existing theme or module and forget to change the domain setting in the po file then it might not be found by SSP. With this warning message you will at least have some indication as to why this might have happened.