-
Notifications
You must be signed in to change notification settings - Fork 698
Fix deprecation of Twig spaceless-filter #2229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29c46ad to
2b725bf
Compare
|
For me, the update in the PR as it is now makes the text in the dialog not break out of the code-box as much. yay! I am not sure where the +++ at end of stylesheet.css |
|
I guess next is working out what needs to change in the docs CI. |
aa666d3 to
21ee440
Compare
|
Fixed the docs. @monkeyiq The slight overflow has been fixed in an update of the simplesamlphp-assets-base package |
* Remove deprecated spaceless-filter * Fix whitespace-issue in converted metadata block * Add update-note
* Remove deprecated spaceless-filter * Fix whitespace-issue in converted metadata block * Add update-note
* Remove deprecated spaceless-filter * Fix whitespace-issue in converted metadata block * Add update-note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## simplesamlphp-2.3 #2229 +/- ##
=======================================================
+ Coverage 44.91% 44.96% +0.05%
Complexity 3896 3896
=======================================================
Files 162 162
Lines 12983 12983
=======================================================
+ Hits 5831 5838 +7
+ Misses 7152 7145 -7 |
* Remove deprecated spaceless-filter * Fix whitespace-issue in converted metadata block * Add update-note
* Remove deprecated spaceless-filter * Fix whitespace-issue in converted metadata block * Add update-note
Closes #2228
The whitespace-issue turns out to be not a clipboard.js issue, but appears to be related to the
<pre>-tag.