Skip to content

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Sep 1, 2024

Closes #2228

The whitespace-issue turns out to be not a clipboard.js issue, but appears to be related to the <pre>-tag.

@tvdijen tvdijen requested review from monkeyiq and thijskh September 1, 2024 20:06
@tvdijen tvdijen force-pushed the deprecation/twig-spaceless branch from 29c46ad to 2b725bf Compare September 1, 2024 20:45
@monkeyiq
Copy link
Contributor

monkeyiq commented Sep 2, 2024

For me, the update in the PR as it is now makes the text in the dialog not break out of the code-box as much. yay!

I am not sure where the code-box-content is being generated from in stylesheet.css. The contents of the code-box still runs a little too far to the right here. (In Chrome, others untested as yet). If I override the width to unset then the content fits nicely in the code-box.

+++ at end of stylesheet.css

.code-box-content {
    width: unset
}

@monkeyiq
Copy link
Contributor

monkeyiq commented Sep 2, 2024

I guess next is working out what needs to change in the docs CI.

@tvdijen tvdijen force-pushed the deprecation/twig-spaceless branch from aa666d3 to 21ee440 Compare September 2, 2024 09:17
@tvdijen
Copy link
Member Author

tvdijen commented Sep 2, 2024

Fixed the docs.

@monkeyiq The slight overflow has been fixed in an update of the simplesamlphp-assets-base package

@tvdijen tvdijen merged commit 6fa3af6 into simplesamlphp-2.3 Sep 2, 2024
@tvdijen tvdijen deleted the deprecation/twig-spaceless branch September 2, 2024 09:19
tvdijen added a commit that referenced this pull request Sep 2, 2024
* Remove deprecated spaceless-filter

* Fix whitespace-issue in converted metadata block

* Add update-note
tvdijen added a commit that referenced this pull request Sep 2, 2024
* Remove deprecated spaceless-filter

* Fix whitespace-issue in converted metadata block

* Add update-note
tvdijen added a commit that referenced this pull request Sep 2, 2024
* Remove deprecated spaceless-filter

* Fix whitespace-issue in converted metadata block

* Add update-note
@codecov
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.96%. Comparing base (39e8655) to head (21ee440).
Report is 3 commits behind head on simplesamlphp-2.3.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             simplesamlphp-2.3    #2229      +/-   ##
=======================================================
+ Coverage                44.91%   44.96%   +0.05%     
  Complexity                3896     3896              
=======================================================
  Files                      162      162              
  Lines                    12983    12983              
=======================================================
+ Hits                      5831     5838       +7     
+ Misses                    7152     7145       -7     

tvdijen added a commit that referenced this pull request Sep 2, 2024
* Remove deprecated spaceless-filter

* Fix whitespace-issue in converted metadata block

* Add update-note
tvdijen added a commit that referenced this pull request Sep 23, 2024
* Remove deprecated spaceless-filter

* Fix whitespace-issue in converted metadata block

* Add update-note
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants