Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.93%. Comparing base (64d0973) to head (674a913).

@@                   Coverage Diff                   @@
##             simplesamlphp-2.3    #2216      +/-   ##
=======================================================
- Coverage                44.94%   44.93%   -0.01%     
  Complexity                3893     3893              
=======================================================
  Files                      162      162              
  Lines                    12975    12974       -1     
=======================================================
- Hits                      5831     5830       -1     
  Misses                    7144     7144              

Thanks @monkeyiq for diving into this.. I think in this case we could just remove the strotolower-line..

That CI test that is failing is checking if language.parameter.name value is transformed to lower case. So if folks were using things like 'Es' to select a language then that will no longer work.

I guess that's OK.. I really doubt people are adding values to the list, they only remove what is not needed.

I wonder if the Brazilian translations ever worked, because it is now just using pt..
It's being reduced from pt_BR to to in Localization::getLangPath..

I see what you mean in getLangPath with the explode('_', $this->langcode);. I suspect in this case it is still working because going from pt_BR to pt still gives Portuguese.

I think in this case we might want to rename the pt-br directory to pt_BR and try that full path first before falling back to the first two chars only. IIRC there are locale choices where the language is the same but the customs of the locale might want a different translation or other arangement.

Yeah, I did that (renaming pt-br directory to pt_BR and test that one before falling back to pt) and that gave me completely different translations.. I'll create yet another PR to fix this too, and remain backwards compatible.

Can you see if you can restore BC on the admin-password issue? Maybe I can release 2.3.1 by the end of this week then

This should not have been merged with broken tests by the way.. Fixed in b46c8da