Skip to content

Bugfix: Fix regression in language codes #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
monkeyiq merged 3 commits into from
Aug 23, 2024
Merged

Bugfix: Fix regression in language codes #2215

monkeyiq merged 3 commits into from
Aug 23, 2024

Conversation

@tvdijen
Copy link
Member

@tvdijen tvdijen commented Aug 23, 2024 •
edited
Loading

Closes #2214

Backport to 2.4 & 2.3 release branches.

@tvdijen tvdijen added the bug label Aug 23, 2024
@monkeyiq
Copy link
Contributor

monkeyiq commented Aug 23, 2024

After digging into the Symfony docs I am happy with this PR. I have also tested these functions against the following fragment which I include here.

echo "pt_BR lang " . Languages::getName("pt_BR") . "\n";
echo "pt_BR loc  " . Locales::getName("pt_BR") . "\n";
echo "pt_BR lang " . Languages::exists("pt_BR") . "\n";
echo "pt_BR loc  " . Locales::exists("pt_BR") . "\n";
echo "pt_BR lang " . Languages::exists("pt-br") . "\n";
echo "pt_BR loc  " . Locales::exists("pt-br") . "\n";
echo "langs\n";
//var_dump(Languages::getNames());
echo "locales\n";
//var_dump(Locales::getNames());

@monkeyiq monkeyiq merged commit e3cf434 into master Aug 23, 2024
monkeyiq pushed a commit that referenced this pull request Aug 23, 2024
@tvdijen @monkeyiq
Bugfix: Fix regression in language codes (#2215)
c78a595 
* Use Locales instead of Languages

* Rename locales to match ISO-standard

* Add upgrade note
monkeyiq pushed a commit that referenced this pull request Aug 23, 2024
@tvdijen @monkeyiq
Bugfix: Fix regression in language codes (#2215)
924e2ce 
* Use Locales instead of Languages

* Rename locales to match ISO-standard

* Add upgrade note
@monkeyiq
Copy link
Contributor

monkeyiq commented Aug 23, 2024

Merged and cherry picked back into 2.4 and 2.3.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect language.available values in config/config.php.dist

2 participants

@tvdijen @monkeyiq