Skip to content

Clean repo & release-script - #1717

Merged
tvdijen merged 10 commits into
masterfrom
vfeature/composer-archive
Nov 15, 2022
Merged

tvdijen merged 10 commits into
masterfrom
vfeature/composer-archive

Conversation

@tvdijen

@tvdijen tvdijen commented Nov 11, 2022

Copy link
Copy Markdown
Member

This PR does the following things:

  • Removes data/ cache/ and log/ dir from the repo and/or release tarball. They shouldn't be in the installation directory. Their default values have been unset in the config template and they programmatically default to the system's temp dir.
  • The config- and metadata templates have been moved to .dist files in the config- and metadata-dir. We did basically the same during the release build and it allows us to remove two dirs.
  • Instead of building the release tarball ourselves we now use composer to do the job.

@tvdijen
tvdijen requested a review from thijskh November 11, 2022 20:55
@codecov

codecov Bot commented Nov 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1717 (5416e10) into master (68a6b3e) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1717   +/-   ##
=========================================
  Coverage     42.67%   42.67%           
  Complexity     2207     2207           
=========================================
  Files            83       83           
  Lines          6194     6194           
=========================================
  Hits           2643     2643           
  Misses         3551     3551           

@tvdijen

tvdijen commented Nov 11, 2022

Copy link
Copy Markdown
Member Author

Note: remove v2.0.0-beta99 tag when merged - also from packagist

Comment thread bin/build-release.sh
Comment thread modules/core/src/Storage/SQLPermanentStorage.php Outdated
@tvdijen
tvdijen force-pushed the vfeature/composer-archive branch from 04960ea to 5416e10 Compare November 15, 2022 20:19
@tvdijen
tvdijen merged commit ecd5db1 into master Nov 15, 2022
@tvdijen
tvdijen deleted the vfeature/composer-archive branch November 15, 2022 20:27
tvdijen added a commit that referenced this pull request Nov 15, 2022
* Change build-script to leverage composer archive

* No longer include data/ cache/ and log/ directories. They don't belong in the install-dir

* Remove unnecessary .gitkeep files

* Merge config&config-templates and metadata&metadata-templates; templates renamed to .dist

* Reduce git clone overhead

* Throw an exception if datadir not set

Co-authored-by: Thijs Kinkhorst <thijs@kinkhorst.com>
@github-actions

Copy link
Copy Markdown
Contributor

\n This pull request has been automatically locked since there has \n not been any recent activity after it was closed.\n Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants