entityID change affects saml:SP too - #1710
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1710 +/- ##
============================================
+ Coverage 42.55% 42.59% +0.03%
- Complexity 2205 2206 +1
============================================
Files 83 83
Lines 6194 6196 +2
============================================
+ Hits 2636 2639 +3
+ Misses 3558 3557 -1 |
|
We've discussed this internally and we would like to throw an exception when people do not change the default entityID. You think you can add that to this PR? |
Done. It wasn't clear if you wanted to do that for the example in metadata-templates/saml20-idp-hosted.php as well, so I've added that as a separate commit. Feel free to leave that out if you don't want to use that :) |
|
Yes, that was what I had in mind, but I lacked the time to make this PR myself! Thanks a lot!! |
* entityID change affects saml:SP too * Generate exception for example entityID (SP) * Make entityId consistent with examples * Generate exception for example entityID (IdP) * Add some use-statements Co-authored-by: Tim van Dijen <tvdijen@gmail.com>
|
\n This pull request has been automatically locked since there has \n not been any recent activity after it was closed.\n Please open a new issue for related bugs. |
2 participants
Update the examples and documentation for saml:SP to be consistent with the notion that entityIDs are no longer
dynamically generated if the 'entityID' config option is null.