Make all NameID authproc-filters use identifyingAttribute - #1709
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1709 +/- ##
============================================
+ Coverage 42.55% 42.57% +0.01%
Complexity 2205 2205
============================================
Files 83 83
Lines 6194 6194
============================================
+ Hits 2636 2637 +1
+ Misses 3558 3557 -1 |
tvdijen
pushed a commit
that referenced
this pull request
Oct 25, 2022
Contributor
|
\n This pull request has been automatically locked since there has \n not been any recent activity after it was closed.\n Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade notes for 2.0 note that the user id attribute in core:TargetedID has been renamed 'identifyingAttribute'. Similarly, the new PairwiseID and SubjectID filters use 'identifyingAttribute' as well, as does the consent module.
That creates a situation where some NameID-related authproc filters use 'attribute' and some use 'identifyingAttribute' to configure the user-identifying attribute.
It might be desirable to create some consistency and standardise on identifyingAttribute. This pull request does that.
It also updates the documentation in modules/core/docs/authproc_targetedid.md to match the earlier change for core:TargetedID.