Skip to content

Fix: ADFS IdP loads metadata of disabled SAML IdP - #1565

Merged
tvdijen merged 1 commit into
simplesamlphp:masterfrom
m0ark:fix-adfs-only-logout
Sep 15, 2022
Merged

tvdijen merged 1 commit into
simplesamlphp:masterfrom
m0ark:fix-adfs-only-logout

Conversation

@m0ark

@m0ark m0ark commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Fixes #1564

@codecov

codecov Bot commented Jan 19, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1565 (d4bac55) into master (b7e26e3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1565      +/-   ##
============================================
- Coverage     44.09%   44.09%   -0.01%     
- Complexity     3680     3681       +1     
============================================
  Files           156      156              
  Lines         10889    10890       +1     
============================================
  Hits           4802     4802              
- Misses         6087     6088       +1     

@tvdijen

tvdijen commented Jan 19, 2022

Copy link
Copy Markdown
Member

This shouldn't be going into master, because ADFS support was removed there.
It was supposed to be removed, but I see we still have a hard dependency on the adfs-module..

@m0ark

m0ark commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

Even though module-adfs has been moved to another repository, the master branch still contains this ADFS specific piece of code.
So what do you suggest?

@m0ark

m0ark commented Jan 19, 2022

Copy link
Copy Markdown
Contributor Author

I just checked why this part has been introduced at all.
It seems that this part is going to be obsolete as soon as my other PR (#1553) is accepted since it handles propagating logout requests properly.

@tvdijen
tvdijen force-pushed the fix-adfs-only-logout branch from b7363d4 to d4bac55 Compare September 15, 2022 21:52
@tvdijen
tvdijen merged commit e1c32bd into simplesamlphp:master Sep 15, 2022
tvdijen pushed a commit that referenced this pull request Sep 15, 2022
@github-actions

Copy link
Copy Markdown
Contributor

\n This pull request has been automatically locked since there has \n not been any recent activity after it was closed.\n Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ADFS IdP loads metadata of disabled SAML IdP

2 participants