Skip to content

upgrading cmake - #950

Open
lemire wants to merge 1 commit into
masterfrom
modern_cmake
Open

upgrading cmake#950
lemire wants to merge 1 commit into
masterfrom
modern_cmake

Conversation

@lemire

@lemire lemire commented Mar 25, 2026

Copy link
Copy Markdown
Member

Upgrades cmake and use CMAKE_COMPILE_WARNING_AS_ERROR.

@pauldreik

Copy link
Copy Markdown
Collaborator

is there a particular reason to upgrade cmake?

the mingw ci job failures seem unrelated.

I am for upgrading cmake. But it feels somewhat odd that we hold ourselves back to C++11 while demanding a cmake released 2023.

@lemire

lemire commented Mar 26, 2026

Copy link
Copy Markdown
Member Author

@pauldreik We don't have to upgrade.

But it feels somewhat odd that we hold ourselves back to C++11 while demanding a cmake released 2023.

This can be revisited. Although, of course, it would require a major release.

I don't think we can require anything beyond C++20, however. Yet C++20 would be fine. We could have two tracks, maintain security patches for the current version, and go C++20 with a new major release.

@pauldreik

Copy link
Copy Markdown
Collaborator

I think this sounds like a good proposal - switch to C++20 and a more modern cmake in the next major release, and possibly do security patches on the current release, for those needing to stay on C++11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants