Improve the performance of validate utf8 and ascii on short inputs#929
Closed
Improve the performance of validate utf8 and ascii on short inputs#929
Conversation
Collaborator
Collaborator
Member
Author
|
I am closing this PR. The reason we had this effect is that my build was in debug mode. :-/ Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Our current implementation of validate utf8 and validate ascii functions use a full SIMD approach, using 64-byte blocks. It works well for larger blocks, but for tiny inputs, it can deliver good performance.
LLVM 20/Apple M4.
Current main branch
This PR: