fix ie bug with null and orphans elements

mhevery · mhevery · commit 2a7cd9f39089 · 2010-04-26T16:49:34.000-07:00
diff --git a/src/Angular.js b/src/Angular.js
@@ -91,12 +91,15 @@ function extensionMap(angular, name) {
 }
 
 function jqLiteWrap(element) {
-  if (isString(element)) {
-    var div = document.createElement('div');
-    div.innerHTML = element;
-    element = new JQLite(div.childNodes);
-  } else if (!(element instanceof JQLite) && isElement(element)) {
-    element =  new JQLite(element);
+  // for some reasons the parentNode of an orphan looks like null but its typeof is object.
+  if (element) {
+    if (isString(element)) {
+      var div = document.createElement('div');
+      div.innerHTML = element;
+      element = new JQLite(div.childNodes);
+    } else if (!(element instanceof JQLite) && isElement(element)) {
+      element =  new JQLite(element);
+    }
   }
   return element;
 }
diff --git a/src/Compiler.js b/src/Compiler.js
@@ -132,7 +132,7 @@ Compiler.prototype = {
       directives = false;
       var parent = element.parent();
       template.addInit(widget.call(selfApi, element));
-      if (parent) {
+      if (parent && parent[0]) {
         element = jqLite(parent[0].childNodes[elementIndex]);
       }
     }
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -220,19 +220,25 @@ JQLite.prototype = {
     return this[0].innerHTML;
   },
 
-  parent: function() { return jqLite(this[0].parentNode);},
+  parent: function() {
+    return jqLite(this[0].parentNode);
+  },
+
   clone: function() { return jqLite(this[0].cloneNode(true)); }
 };
 
 if (msie) {
   extend(JQLite.prototype, {
     text: function(value) {
       var e = this[0];
-      if (isDefined(value)) {
-        e.innerText = value;
-      }
       // NodeType == 3 is text node
-      return e.nodeType == 3 ? e.nodeValue : e.innerText;
+      if (e.nodeType == 3) {
+        if (isDefined(value)) e.nodeValue = value;
+        return e.nodeValue;
+      } else {
+        if (isDefined(value)) e.innerText = value;
+        return e.innerText;
+      }
     },
 
     trigger: function(type) {

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ Compiler.prototype = {`
`132`	`132`	`directives = false;`
`133`	`133`	`var parent = element.parent();`
`134`	`134`	`template.addInit(widget.call(selfApi, element));`
`135`		`- if (parent) {`
	`135`	`+ if (parent && parent[0]) {`
`136`	`136`	`element = jqLite(parent[0].childNodes[elementIndex]);`
`137`	`137`	`}`
`138`	`138`	`}`