Overhaul frames #2281
Draft
Overhaul frames #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
deframerate
branch
3 times, most recently
from
8f99e65 to
c378aa6
Compare
|
Hmmm, where exactly was I in this?
|
BREAKING CHANGE: Access to the global list of declared frames at `SILE.frames` has been deprecated in favor of a registry of frames accessed via modules.
- removed direct access to from - added deprecation warning when accessing - updated documentation to indicate that is deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanitize the frame type like other things we're passing around, keep track of them attached to modules via a registry, etc.