merge Sigma changes into main branch - #9
Merged
Merged
Conversation
-- Technically, unpivot has some stricter expr requirements (eg instead of expr for ident in col_list it should be <column> for ident in col_list). I haven't been able to navigate to find this stricter definition yet, but maybe we want this fix ASAP.
* Use enum to prevent &'static str lifetime issues -- Could also use `serde(bound(deserialize = "'de: 'static"))` -- But I think that will need to be applied on all structs -- that depend on Expr... which I assume will be ubiquitous * Make WindowSpec serializable * Fix more static str stuff * Fixed tests * Fixed all compilation errors * Run clippy --fix * Fixd lint errors * Fix more lint errors * Fix remaining lint issues
* Fixed trivial tests failures * Fixed more tests * Ignored backcompat breaks... for now * More simple tests fixes * Fixed tests... but not sure whether this is right * Clippy * cargo fmt * Fixed regression #1 * Fixed second regression * Ignore snowflake numeric failing test
* Added regression tests * Added test for sigma-related parser changes * Amended comments * Removed extraneous println * Fixed build errors part 1 * Manual cargo fmt because it's hanging on my machine * When you fail at %s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these are all the changes that I and @markwongsk (now reincarnated as @mwong-sigma) have made to this repo since we forked it