Omit providing an error when unnecessary (in protobuf api)

matehat · matehat · commit 2ec61e00a681 · 2013-05-03T16:48:45.000-04:00
diff --git a/lib/protocol-buffers-client.js b/lib/protocol-buffers-client.js
@@ -17,6 +17,8 @@ var ProtocolBuffersClient = function ProtocolBuffersClient(options) {
   this.mapreduce = new ProtocolBuffersMapReduceClient(this._defaults, execute);
 }
 
+var expectedResponseOperations = ['get', 'getBucket', 'getBuckets', 'keys'];
+
 util.inherits(ProtocolBuffersClient, Client);
 
 ProtocolBuffersClient.prototype.get = function(bucket, key, options, callback) {
@@ -89,7 +91,7 @@ ProtocolBuffersClient.prototype._execute = function(operation, meta, includePara
       data = meta.parse(response.content[0].value);
     }
 
-    if (Object.keys(response).length == 0) {
+    if (expectedResponseOperations.indexOf(operation) > -1 && Object.keys(response).length == 0) {
       error = {notFound: true};
     }
 

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@ var ProtocolBuffersClient = function ProtocolBuffersClient(options) {`
`17`	`17`	`this.mapreduce = new ProtocolBuffersMapReduceClient(this._defaults, execute);`
`18`	`18`	`}`
`19`	`19`
	`20`	`+var expectedResponseOperations = ['get', 'getBucket', 'getBuckets', 'keys'];`
	`21`	`+`
`20`	`22`	`util.inherits(ProtocolBuffersClient, Client);`
`21`	`23`
`22`	`24`	`ProtocolBuffersClient.prototype.get = function(bucket, key, options, callback) {`
`@@ -89,7 +91,7 @@ ProtocolBuffersClient.prototype._execute = function(operation, meta, includePara`
`89`	`91`	`data = meta.parse(response.content[0].value);`
`90`	`92`	`}`
`91`	`93`
`92`		`- if (Object.keys(response).length == 0) {`
	`94`	`+ if (expectedResponseOperations.indexOf(operation) > -1 && Object.keys(response).length == 0) {`
`93`	`95`	`error = {notFound: true};`
`94`	`96`	`}`
`95`	`97`