Skip to content
This repository was archived by the owner on Jun 18, 2025. It is now read-only.

Add generic signum function [in progress]#323

Open
sritchie wants to merge 2 commits into
mainfrom
sritchie/sgn
Open

Add generic signum function [in progress]#323
sritchie wants to merge 2 commits into
mainfrom
sritchie/sgn

Conversation

@sritchie
Copy link
Copy Markdown
Member

@sritchie sritchie commented Mar 9, 2021

Closes #294. Before we get this done, we have to decide what we want:

csgn, ie, which half-plane the number is in? https://www.maplesoft.com/support/help/maple/view.aspx?path=csgn&term=csgn

OR do we want the version that is equivalent to normalize?

@sritchie sritchie added this to the 0.21.0 milestone Nov 21, 2021
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #323 (1a9db2f) into main (79febce) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #323      +/-   ##
==========================================
- Coverage   85.19%   85.17%   -0.02%     
==========================================
  Files          97       97              
  Lines       13010    13014       +4     
  Branches      697      697              
==========================================
+ Hits        11084    11085       +1     
- Misses       1229     1232       +3     
  Partials      697      697              
Impacted Files Coverage Δ
src/sicmutils/generic.cljc 78.64% <25.00%> (-0.78%) ⬇️
src/sicmutils/polynomial.cljc 83.01% <0.00%> (-0.16%) ⬇️
src/sicmutils/numsymb.cljc 92.96% <0.00%> (ø)
src/sicmutils/rational_function.cljc 80.16% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79febce...1a9db2f. Read the comment docs.

@sritchie sritchie removed this from the 0.21.0 milestone Jan 23, 2022
@sritchie sritchie force-pushed the main branch 3 times, most recently from afa6dd7 to c33ef42 Compare February 15, 2022 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add "sgn" generic function

2 participants