Add confirmation prompts for destructive commands: clear, evict, check --fix - #6
Open
shubham-dce wants to merge 1 commit into
Open
Add confirmation prompts for destructive commands: clear, evict, check --fix#6shubham-dce wants to merge 1 commit into
shubham-dce wants to merge 1 commit into
Conversation
This was referenced Aug 13, 2026
Owner
Author
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a confirmation prompt for the three destructive commands
clear,evict TAG,check --fix, it 'y'(yes) provided then it goes ahead with the opted operation, else aborts.Changes
confirm(prompt)a shared method to be used by all theclear,evictandcheckmethods. It returns true if 'y' or 'yes' opted.-y/--yespassed with commands skips the prompt, this is valid only for the above mentioned destructive commands.checkonly shows prompt if--fixflag is passed.Testing
FakeExtraArgsclass with a new kwargyes(by default False) to test the confirmation prompttest_clear_removes_all_items,test_evict_removes_items_with_matching_tagto behave as-y/--yesflag is provided.