Adds scoring and single-worst-candidate eviction - #15
Open
shubham-dce wants to merge 1 commit into
Open
Conversation
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds scoring for sampled candidates, and evicition of a single worst candidate from those sampled candidates.
Changes
_scoring(candidates)scores the selected sample of candidates based onaccessed_count/max(size, 1), and returns the candidate with worst(low) score. The0size case is handled, and returnsNonefor an empty candidates list._evict_worst(candidates)removes the worst-scoring candidate now. Also cleans up the file associated with it, if any. Follow the same patters as existing__delitem__method.retry=Truein the transaction in the_evict_worstas retry loop has no cap on blocking time, if the lock is held by another writer. It will fight the planned graceful shutdown for the background thread (upcoming PRs).Testing