Skip to content

Fix creative_review_settings test #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlos-villavicencio-adsk merged 1 commit into from
Apr 15, 2025
Merged

Fix creative_review_settings test #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1004,7 +1004,6 @@ def test_preferences_read(self):
resp = self.sg.preferences_read()

expected = {
"creative_review_settings": "",
"date_component_order": "month_day",
"duration_units": "days",
"format_currency_fields_decimal_options": "$1,000.99",
Expand All @@ -1027,6 +1026,12 @@ def test_preferences_read(self):
self.assertIn("view_master_settings", resp)
resp.pop("view_master_settings")

# Simply make sure creative review settings are there. These change frequently and we
# don't want to have the test break because Creative Review changed or because we didn't
# update the test.
self.assertIn("creative_review_settings", resp)
resp.pop("creative_review_settings")

self.assertEqual(expected, resp)

# all filtered
Expand Down
Loading