SG-13608 Fixes a bug where url parsing will fail in mimetypes #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willis102
changed the title
thebeeland
approved these changes
Aug 13, 2019
Contributor
thebeeland
left a comment
thebeeland
left a comment
There was a problem hiding this comment.
Assuming tests pass in 2.6/2.7/3.7 when run locally (since CI is broken right now), then this looks fine to me.
since this method is used in the shotgun api.
willis102
force-pushed
the
mimetypes_url_parsing_fix
branch
from
dc3af57 to
44bc2bf
Compare
Contributor
Author
|
Replaced with PR #207 -- since the mimetypes module does not need to be used in python3, there's no need for it to be python3 compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where URL parsing fails because mimetypes attempts to call a urllib function that no longer exists. Affects Windows installs with Python 2.7.0-2.7.9 only.