Skip to content

Support all valid PHP version file values - #1121

Merged
shivammathur merged 2 commits into
shivammathur:developfrom
Perlence:fix/php-version-file-values
Sep 17, 2026
Merged

shivammathur merged 2 commits into
shivammathur:developfrom
Perlence:fix/php-version-file-values

Conversation

@Perlence

Copy link
Copy Markdown
Contributor

This PR allows version files to use partial versions and aliases accepted by the php-version input while preserving support for both plain .php-version files and asdf-style php entries.

This aligns with setup-node. While asdf-php generally requires X.Y.Z versions in .tool-versions, other managers like mise allow fuzzy versions, such as 8 and 8.4.

In case this PR introduced TypeScript/JavaScript code changes:

  • I have written test cases for the changes in this pull request
  • I have run npm run format before the commit.
  • I have run npm run lint before the commit.
  • I have run npm run release before the commit.
  • npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

  • I have checked the edited scripts for syntax.
  • I have tested the changes in an integration test (If yes, provide workflow YAML and link).

Allow version files to use partial versions and aliases accepted by the
php-version input while preserving support for both plain .php-version
files and asdf-style php entries.
@Perlence
Perlence force-pushed the fix/php-version-file-values branch from 4c8e788 to 87850e8 Compare September 17, 2026 07:55
@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e3f88f3) to head (756bdc2).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          977       977           
  Branches       340       344    +4     
=========================================
  Hits           977       977           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shivammathur
shivammathur merged commit 0bbee91 into shivammathur:develop Sep 17, 2026
70 checks passed

This branch was successfully deployed

1 active deployment
codecov — 756bdc29 Deployed Sep 17, 2026 by shivammathur via Run (windows-latest) #1173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants